[Bug 709224] audio/videodecoder: Not returning GST_FLOW_EOS when after segment

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=709224
  GStreamer | gst-plugins-base | git

--- Comment #64 from Thiago Sousa Santos <thiagossantos at gmail.com> 2014-05-24 14:28:19 UTC ---
(In reply to comment #63)
> Review of attachment 277086 [details]:
> 
> ::: gst/gstpad.c
> @@ +392,3 @@
>    pad->priv->events_cookie = 0;
>    pad->priv->last_cookie = -1;
> +  pad->priv->last_flowret = GST_FLOW_OK;
> 
> I think initially it should be GST_FLOW_FLUSHING until the pad is activated...
> and GST_FLOW_FLUSHING again when it's deactivated. Otherwise good, just see the
> locking comment.

Setting it to FLUSHING seems more consistent with the overall GstPads behavior
but Tim wanted to use it to do some further error tracking in the pipeline.
Resetting it to FLUSHING will force Tim's idea to run before the pipeline was
put to NULL after an error, it should be fine but I'd like him to double-check
that we meet his requirements as well.

After his review I'll create new patches.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.