[Bug 739581] basetransform: First query downstream before answering the query position

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=739581
  GStreamer | gstreamer (core) | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #289922|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-11-04 09:56:22 UTC ---
Review of attachment 289922:
 --> (https://bugzilla.gnome.org/review?bug=739581&attachment=289922)

Not sure this is correct, the upstream/downstream position might be different
to the position inside basesink.

::: libs/gst/base/gstbasetransform.c
@@ +1497,3 @@
       gst_query_parse_position (query, &format, NULL);
+      ret = gst_pad_peer_query (otherpad, query);
+      if (ret == FALSE && format == GST_FORMAT_TIME

Don't compare booleans by equality. if (!ret && ...)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.