[Bug 739581] basetransform: First query downstream before answering the query position

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=739581
  GStreamer | gstreamer (core) | unspecified

--- Comment #3 from Thibault Saunier <tsaunier at gnome.org> 2014-11-04 10:50:47 UTC ---
(In reply to comment #2)
> Review of attachment 289922 [details]:
> 
> Not sure this is correct, the upstream/downstream position might be different
> to the position inside basesink.

FMPOV when an upstream element send a downstream POSITION query what should be
return is the position at the end of the pipeline by default, not the position
of some random element is. That is what that patch is about.

> ::: libs/gst/base/gstbasetransform.c
> @@ +1497,3 @@
>        gst_query_parse_position (query, &format, NULL);
> +      ret = gst_pad_peer_query (otherpad, query);
> +      if (ret == FALSE && format == GST_FORMAT_TIME
> 
> Don't compare booleans by equality. if (!ret && ...)

FALSE being #define FALSE 0 that is the exact same thing, anyway, doing that.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.