[Bug 740058] pngparse: improve parsing of the image

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740058
  GStreamer | gst-plugins-bad | unspecified

Reynaldo H. Verdejo Pinochet <reynaldo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #290955|none                        |needs-work
             status|                            |

--- Comment #5 from Reynaldo H. Verdejo Pinochet <reynaldo at opendot.cl> 2014-11-20 12:26:04 UTC ---
(From update of attachment 290955)

> [...]
>diff --git a/gst/videoparsers/gstpngparse.h b/gst/videoparsers/gstpngparse.h
>index 3574481..2e8f234 100644
>--- a/gst/videoparsers/gstpngparse.h
>+++ b/gst/videoparsers/gstpngparse.h
>@@ -49,6 +49,8 @@ struct _GstPngParse
> 
>   guint width;
>   guint height;

wouldn't hurt making this explicitly guint32 to match the
spec? I understand PNG uses 32 bits unsigned integers for
these values. Just a nit anyway.

>+  guint32 skip_length;

Coming from the above I'd make this guint64 or, unless my
understanding is wrong, you risk overflowing at reading
perfectly valid (albeit rather big) png frames.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.