[Bug 740058] pngparse: improve parsing of the image

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Nov 20 04:35:33 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=740058
  GStreamer | gst-plugins-bad | unspecified

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |t.i.m at zen.co.uk
     Ever Confirmed|0                           |1

--- Comment #6 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-11-20 12:35:31 UTC ---
> >   guint width;
> >   guint height;
> 
> wouldn't hurt making this explicitly guint32 to match the
> spec? I understand PNG uses 32 bits unsigned integers for
> these values. Just a nit anyway.

Rule #1 of patch club: don't change existing things that don't need changing,
keep the changeset as small as possible :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list