[Bug 727826] check: update internal libcheck copy from 0.9.8 to 0.9.12
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Tue Nov 25 09:40:02 PST 2014
https://bugzilla.gnome.org/show_bug.cgi?id=727826
GStreamer | gstreamer (core) | git
--- Comment #13 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-11-25 17:39:56 UTC ---
Patches 1+2 should be squashed IMHO, I don't see the point in keeping them
separate. Same for all the trailing white space stuff underneath libcheck/*
from Patch 3 that should just be squashed into the same commit.
Patch 3: the changes in libs/gst/check/gstcheck.[ch] (gstreamer code) should be
separate from those in libcheck/*. The copyright fix you can probably just
re-apply with 'git cherry-pick $previous_commit' :) Not sure if we need to fix
up trailing white spaces in gstreamer headers/code as part of this? (I'm sure
there are more..)
Patch 4:
- All that clutter in configure.ac should probably be moved into
m4/check-checks.m4 ?
- test "x$ac_cv_func_clock_gettime" == "xyes" : this should be a single = for
compatibility reasons IIRC
- why is "ASSERT_{CRITICAL,WARNING}() calls new _ck_assert_failed() instead
of _fail_unless()" part of this patch and not a separate patch? (or done at
all? is it cleanup? does _fail_unless() not work any more?)
- #include <stdint.h> -> #include "_stdint.h" ?
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list