[Bug 727826] check: update internal libcheck copy from 0.9.8 to 0.9.12

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727826
  GStreamer | gstreamer (core) | git

--- Comment #14 from Sebastian Rasmussen <sebras at hotmail.com> 2014-11-29 13:56:20 UTC ---
> Patches 1+2 should be squashed IMHO, I don't see the point in keeping them
> separate. Same for all the trailing white space stuff underneath libcheck/*
> from Patch 3 [details] that should just be squashed into the same commit.

Patches 1+2 have been squashed.

> Patch 3 [details]: the changes in libs/gst/check/gstcheck.[ch] (gstreamer
> code) should be separate from those in libcheck/*. The copyright fix you can
> probably just re-apply with 'git cherry-pick $previous_commit' :) Not sure if
> we need to fix up trailing white spaces in gstreamer headers/code as part of
> this? (I'm sure there are more..)

I skipped all the other whitespace fixes are you adviced and also included the
FSF update in the 1+2 patch.

> Patch 4 [details]: 
>  - All that clutter in configure.ac should probably be moved into
> m4/check-checks.m4 ?

that makes sense given AG_GST_CHECK_CHECKS which I wasn't aware of.
I moved as much stuff as possible into that macro, but I still need to
muck about with that AX_PTHREAD thingy in order to get HAVE_PTHREAD
accessible in the checks in m4/check-checks.m4

>  - test "x$ac_cv_func_clock_gettime" == "xyes" : this should be a single = for
> compatibility reasons IIRC

sh's test used = for equality testing, not ==. I know this. :-/

>  - why is  "ASSERT_{CRITICAL,WARNING}() calls new _ck_assert_failed() instead
> of _fail_unless()" part of this patch and not a separate patch? (or done at
> all? is it cleanup? does _fail_unless() not work any more?) 

no, it doesn't work any more. in check 0.9.9 _fail_unless() was replaced by the
new _ck_assert_msg() that in check 0.9.12 was renamed _ck_assert_failed(). I
updated the commit message with this information to give more context as none
of it was obvious as you aptly point out in the review comment.

I wanted to combine all the gstreamer-specific changes into a single commit
so it is easy to find those the next time check is updated so this is my
reasoning for wanting to keep it together with the other changes.

>  - #include <stdint.h> -> #include "_stdint.h" ?

ah, the good old AX_CREATE_STDINT_H that creates the _stdint.h, who knew of it?
fixed.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.