[Bug 737401] videobox: Use videoconvert APIs for format conversions

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=737401
  GStreamer | gst-plugins-good | git

--- Comment #5 from Wim Taymans <wim.taymans at gmail.com> 2014-11-26 10:58:52 UTC ---
(In reply to comment #4)
> Wim, using video-converter still crops the right side only (instead of left).
> For example, I ran the pipeline 
> gst-launch-1.0 videotestsrc ! "video/x-raw,format={RGB},height=480,width=640" !
> videobox left=50 right=-50 ! videoconvert ! ximagesink
> This should have cropped left region. But, it cropped the right side.

Works for me, what are you doing? Are you using this patch? I don't see you
setting any offset in the options?

> 
> Part of the problem is because "unpack_RGB()" in video-format.c doesn't
> consider 'x' offset (actually, none of unpack functions do).
> And, pack functions do not have 'x' offset parameter. 
> https://bugzilla.gnome.org/show_bug.cgi?id=740228 is reported for this.

yes, we need to add support for unpacking from a different offset.

> 
> Once pack functions support 'x' parameter, I think we need to add 'x' to
> PACK_FRAME macro in video-converter.c

no, pack_frame does not need an x parameter, only unpack.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.