[Bug 737401] videobox: Use videoconvert APIs for format conversions

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=737401
  GStreamer | gst-plugins-good | git

--- Comment #6 from RaviKiran <ravi.kiran at samsung.com> 2014-11-27 09:17:37 UTC ---
Created an attachment (id=291621)
 --> (https://bugzilla.gnome.org/attachment.cgi?id=291621)
screenshots of output

I used latest video-converter code. 
In videobox, while creating new video-converter, I used the configuration
structure, with values for
GST_VIDEO_CONVERTER_OPT_SRC_X = src_x, GST_VIDEO_CONVERTER_OPT_SRC_Y = src_y,
GST_VIDEO_CONVERTER_OPT_DEST_X = dest_x, GST_VIDEO_CONVERTER_OPT_DEST_Y =
dest_y,
GST_VIDEO_CONVERTER_OPT_SRC_WIDTH = GST_VIDEO_CONVERTER_OPT_DEST_WIDTH = crop_w
GST_VIDEO_CONVERTER_OPT_SRC_HEIGHT = GST_VIDEO_CONVERTER_OPT_DEST_HEIGHT =
crop_h

(Let me know if it is incorrect)

src_x, src_y, dest_x, dest_y, crop_w, crop_h are calculated as in the attached
patch.
For the above pipeline, the values are - src_x = 50, src_y = 0, dest_x = 0,
dest_y = 0, crop_w = 590, crop_h = 480.
In this case it cropped the right side (attached pic VB_VC.png). Output of
original videobox code for same pipeline - VB_O.png

Since unpack_rgb doesn't consider 'x', it unpacks from beginning where as it
should have unpacked from pos 50.
When I added the 'x' offset for unpacking, it cropped the left side correctly. 
However during packing, it left a border at the beginning. (Pic - VB_VC1.png) 

Then I tried a hack - added 'x' offset to src while 'packing'. (Pic -
VB_VC2.png)

Let me know if I got something wrong. Thanks.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.