[Bug 737505] gltestsrc: implement checkers pattern in GLSL

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=737505
  GStreamer | gst-plugins-bad | git

Matthew Waters <ystreet00> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #287321|none                        |reviewed
             status|                            |

--- Comment #3 from Matthew Waters <ystreet00 at gmail.com> 2014-09-29 08:28:08 UTC ---
Review of attachment 287321:
 --> (https://bugzilla.gnome.org/review?bug=737505&attachment=287321)

One small issue :)

::: ext/gl/gstgltestsrc.c
@@ +317,3 @@
+      float result=mod(xy_mod.x+xy_mod.y,2.0); \
+      gl_FragColor.r=step(result,0.5); \
+      gl_FragColor.g=1-gl_FragColor.r; \

'1-gl_FragColor.r' is not glsl spec compliant and the mesa shader compiler
fails with it.

You need to do '1.0-gl_FragColor.r' instead.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.