[Bug 737505] gltestsrc: implement checkers pattern in GLSL
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Mon Sep 29 16:50:20 PDT 2014
https://bugzilla.gnome.org/show_bug.cgi?id=737505
GStreamer | gst-plugins-bad | git
comicfans44 <comicfans44> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #287321|0 |1
is obsolete| |
--- Comment #4 from comicfans44 <comicfans44 at gmail.com> 2014-09-29 23:50:13 UTC ---
Created an attachment (id=287409)
View: https://bugzilla.gnome.org/attachment.cgi?id=287409
Review: https://bugzilla.gnome.org/review?bug=737505&attachment=287409
v3 fix glsl compliant
(In reply to comment #3)
> Review of attachment 287321 [details]:
>
> One small issue :)
>
> ::: ext/gl/gstgltestsrc.c
> @@ +317,3 @@
> + float result=mod(xy_mod.x+xy_mod.y,2.0); \
> + gl_FragColor.r=step(result,0.5); \
> + gl_FragColor.g=1-gl_FragColor.r; \
>
> '1-gl_FragColor.r' is not glsl spec compliant and the mesa shader compiler
> fails with it.
>
> You need to do '1.0-gl_FragColor.r' instead.
fixed, also fix the 'Tab' indent
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list