[Bug 748105] videotestsrc: add a 'max-duration' property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=748105

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk
 Attachment #301900|0                           |1
           is patch|                            |
 Attachment #301900|none                        |needs-work
             status|                            |
 Attachment #301900|application/mbox            |text/plain
          mime type|                            |

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 301900
  --> https://bugzilla.gnome.org/attachment.cgi?id=301900
videotestsrc: add a 'max-duration' property

Thanks for the patch. I think this is a good idea and a useful addition.

Please try to produce the smallest patch posssible, ideally without formatting
changes. We don't run header files through gst-indent, only .c files. Thanks!

I also expect that there will be some more discussion about the name of the
property, perhaps it should just be "duration" instead?

We'll want the same for audiotestsrc as well then.

Couple of other comments:

 - the default value of the property should be -1 for "disabled", not 0.

 - not sure what all this G_MAXLONG business in the param spec is about :)

 - The duration should be reflected in the GstSegment pushed out, and hopefully
the base class will take care of the EOS-ing automatically then. We may require
some clipping in addition for the buffers we produce (so that the last buffer
has a shorter duration to make sure the stream has exactly the duration we
want).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.