[Bug 748105] videotestsrc: add a 'max-duration' property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=748105

--- Comment #3 from Swen Kooij <sk at bigbrother.nl> ---
Thanks for the feedback, it is much appriciated. 

I wasn't aware that only implementation files were run through gst-indent. I'll
produce a new patch with the smallest amount of changes possible. However, when
I ran the implementation file through gst-indent, not only did it fix some of
my formatting mistakes, it also fixed some made by others. Shouldn't they be
fixed as well? I could produce two separate patches, one for my changes, and
one for formatting fixes, not related to the changes I made. Would that be
alright?

As for the name, I had my doubts about it as well. I first wanted to name it
"duration", but "max-duration" seemed more descriptive. 

As for the other comments, I'll take care of them and produce a new fix.
However, the last comment is where I might run into trouble as I am not that
familiar with gstreamer, but I'll see how far I get.

It shouldn't be too hard to port this to audiotestsrc as well, if I have
something working that is "acceptable" then I'll port it to audiotestsrc as
well.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.