[Bug 748141] videoconvert, glcolorconvert: keep colorimetry/chroma-site fields if passthrough

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=748141

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301971|none                        |reviewed
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 301971:
 --> (https://bugzilla.gnome.org/review?bug=748141&attachment=301971)

::: ext/gl/gstglcolorconvertelement.c
@@ +233,3 @@
+            gst_structure_has_field (in_structure, "chroma-site")) &&
+        gst_caps_is_subset (ret, caps)) {
+      gst_caps_replace (&ret, caps);

Why only if it's a subset and those fields exist in the input? Why not always
when it's a subset?


Or alternatively, why not always copy over the fields whenever the input has
them but the output doesn't?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.