[Bug 748141] videoconvert, glcolorconvert: keep colorimetry/chroma-site fields if passthrough

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=748141

--- Comment #4 from Matthieu Bouron <matthieu.bouron at collabora.com> ---
(In reply to Sebastian Dröge (slomo) from comment #3)
> Review of attachment 301971 [details] [review]:
> 
> ::: ext/gl/gstglcolorconvertelement.c
> @@ +233,3 @@
> +            gst_structure_has_field (in_structure, "chroma-site")) &&
> +        gst_caps_is_subset (ret, caps)) {
> +      gst_caps_replace (&ret, caps);
> 
> Why only if it's a subset and those fields exist in the input? Why not
> always when it's a subset?

My intent was to avoid the call to gst_caps_replace if the input does no have
those fields. But I can remove the two checks, if you prefer.

> 
> 
> Or alternatively, why not always copy over the fields whenever the input has
> them but the output doesn't?

I'm not sure if it's really correct to preserve those fields in all the cases.
For example those fields will be "consumed" by the convert element when doing a
yuv->rgb conversion (bt601, bt709 colorimetry setting will help to pick the
right conversion path for example).

Though it might be correct to preserve the fields when doing rgb*->rgb*,
yuv*->yuv*, grey*->grey* conversions.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.