[Bug 727067] udpsrc: set udp buffer size forcibly

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=727067

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #309951|none                        |needs-work
             status|                            |

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 309951:
 --> (https://bugzilla.gnome.org/review?bug=727067&attachment=309951)

::: gst/udp/gstudpsrc.c
@@ +1019,3 @@
+              src->buffer_size, &opt_err)) {
+        GST_ELEMENT_WARNING (src, RESOURCE, SETTINGS, (NULL),
+            ("Could not create forcibly a buffer of requested %d bytes: %s",

"Could not force receive buffer size to %d bytes: %s" seems more descriptive

@@ +1022,3 @@
+                src->buffer_size, opt_err->message));
+        g_error_free (opt_err);
+        opt_err = NULL;

This is equivalent to g_clear_error(&opt_err). Just use that :)

@@ +1070,3 @@
+     * Try to set the buffer_size by using SO_RCVBUFFORCE */
+    if (rcvsize < src->buffer_size) {
+      rcvsize = src->buffer_size;

Instead of having this code here copied twice, please move it into a function
:)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.