[Bug 727067] udpsrc: set udp buffer size forcibly

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=727067

--- Comment #14 from KYUNGNAM BAE <kyungnam.bae at lge.com> ---
Review of attachment 309951:
 --> (https://bugzilla.gnome.org/review?bug=727067&attachment=309951)

Could you give me some advice?

::: gst/udp/gstudpsrc.c
@@ +1019,3 @@
+              src->buffer_size, &opt_err)) {
+        GST_ELEMENT_WARNING (src, RESOURCE, SETTINGS, (NULL),
+      GST_INFO_OBJECT (src, "forcibly setting udp buffer of %d bytes",

I will do that.

@@ +1022,3 @@
+                src->buffer_size, opt_err->message));
+        g_error_free (opt_err);
+          src->buffer_size);

I will change the 1023~1024 line to the g_clear_error function.

@@ +1070,3 @@
+     * Try to set the buffer_size by using SO_RCVBUFFORCE */
+    if (rcvsize < src->buffer_size) {
+      rcvsize = src->buffer_size;

Could you explain it more?

Do you mean that a function is needed for the line 1072 and line 1042?
i.e) Is the "rcvsize = src->buffer_size;" line moved into a function?

Or Does I need to make a function for Line 1012~1033 and Line 1068~1096?
Although I make the function for this, the #if and #elif (line 981 and line
1035) is needed.
So I didn't split the function.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.