[Bug 753021] dashdemux: add a check for seek type in parse_seek function

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753021

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #316372|none                        |needs-work
             status|                            |

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 316372:
 --> (https://bugzilla.gnome.org/review?bug=753021&attachment=316372)

::: ext/dash/gstdashdemux.c
@@ +1268,3 @@

+  /* check if start-type/stop-type is SET */
+  if (start_type != GST_SEEK_TYPE_SET || stop_type == GST_SEEK_TYPE_END) {

That doesn't seem right either.

We should support GST_SEEK_TYPE_NONE for both, and most of the handling of the
other parts is already in gst_segment_do_seek(). Are there any specific seeks
that are failing for you without this patch?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.