[Bug 753021] dashdemux: add a check for seek type in parse_seek function

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753021

--- Comment #10 from Jimmy Ohn <yongjin.ohn at lge.com> ---
(In reply to Sebastian Dröge (slomo) from comment #9)
> Review of attachment 316372 [details] [review]:
> 
> ::: ext/dash/gstdashdemux.c
> @@ +1268,3 @@
>  
> +  /* check if start-type/stop-type is SET */
> +  if (start_type != GST_SEEK_TYPE_SET || stop_type == GST_SEEK_TYPE_END) {
> 
> That doesn't seem right either.
> 
> We should support GST_SEEK_TYPE_NONE for both, and most of the handling of
> the other parts is already in gst_segment_do_seek(). Are there any specific
> seeks that are failing for you without this patch?

Actually, seeks are working well without this patch. I just try to patch about
the "TODO" list in dashdemux.
I think that If start_type isn't set to GST_SEEK_TYPE_SET, we should return the
failed result. So, could you recommend how to check start_type and stop_type in
this code? As you know, I'm newbie of gstreamer:)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.