[Bug 749596] rtsp-over-http authentication failure

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749596

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #313869|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 313869:
 --> (https://bugzilla.gnome.org/review?bug=749596&attachment=313869)

::: gst-libs/gst/rtsp/gstrtspconnection.c
@@ +52,2 @@
 #ifdef HAVE_CONFIG_H
+#include <config.h>

Please don't do any whitespace changes :)

@@ +235,3 @@
+        peer_identity,
+        g_tls_connection_get_interaction (conn),
+        G_TLS_DATABASE_VERIFY_NONE, NULL, &error);

No code-style fixes, unless in a separate patch. But "gst-indent" should
actually revert this part here already. Please run gst-indent on .c files :)

@@ +867,3 @@
  * forever. If @timeout contains a valid timeout, this function will return
+ * #GST_RTSP_ETIMEOUT after the timeout expired.  If @conn is set to tunneled,
+ * @response will contain a response to the tunneling request messages.

How would the caller know if it indeed does contain that, or if no tunnelling
has happened?

@@ +871,3 @@
  * This function can be cancelled with gst_rtsp_connection_flush().
  *
  * Returns: #GST_RTSP_OK when a connection could be made.

Add a "Since: 1.8" marker here

@@ +1101,3 @@
+ * #GST_RTSP_ETIMEOUT after the timeout expired.
+ *
+ * This function can be cancelled with gst_rtsp_connection_flush().

Maybe add a note to the docs that this function is going to cause problems with
tunneling and authentication

@@ +1110,3 @@
+  GstRTSPResult result;
+  GstRTSPMessage *response;
+  response = g_new0 (GstRTSPMessage, 1);

You can allocate this one on the stack like the old function did

@@ +1142,3 @@
   g_snprintf (date_string, len, "%s, %02d %s %04d %02d:%02d:%02d GMT",
+      wkdays[tm.tm_wday], tm.tm_mday, months[tm.tm_mon],
+      tm.tm_year + 1900, tm.tm_hour, tm.tm_min, tm.tm_sec);

This and everything following here is also just code-style / whitespace
changes. Please remove them from the patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.