[Bug 749596] rtsp-over-http authentication failure

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749596

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #313870|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 313870:
 --> (https://bugzilla.gnome.org/review?bug=749596&attachment=313870)

::: gst/rtsp/gstrtspsrc.c
@@ +4519,3 @@
   GstRTSPResult res;
+  GstRTSPMessage *response = NULL;
+  guint8 retry = 0;

Should this be a gboolean and be initialized to FALSE? You only seem to retry
at most once

@@ +4523,1 @@
+  response = g_new0 (GstRTSPMessage, 1);

Why not allocate it on the stack?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.