[Bug 758384] dashdemux: tests: refactor into adaptive_engine components

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=758384

--- Comment #31 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 317117
  --> https://bugzilla.gnome.org/attachment.cgi?id=317117
hlsdemux: tests: add test of parsing the EXT-X-STREAM-INF tag

>hlsdemux: tests: add test of parsing the EXT-X-STREAM-INF tag

You are changing the behaviour of code here in a commit that says "add test",
which seems suboptimal to me (although you do mention it of course).

>@@ -234,6 +234,16 @@ parse_attributes (gchar ** ptr, gchar ** a, gchar ** v)
>   *v = p = g_utf8_strchr (*ptr, -1, '=');
>   if (*v) {
>     *v = g_utf8_next_char (*v);
>+    if (**v == '"') {
>+      ve = g_utf8_next_char (*v);
>+      if (ve) {
>+        ve = g_utf8_strchr (ve, -1, '"');
>+        if (ve) {
>+          *v = g_utf8_next_char (*v);
>+          *ve = '\0';
>+        }
>+      }
>+    }
>     *p = '\0';
>   } else {

So we just unconditionally unquote all values now?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.