[Bug 758384] dashdemux: tests: refactor into adaptive_engine components

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=758384

--- Comment #32 from A Ashley <bugzilla at ashley-family.net> ---
(In reply to Tim-Philipp Müller from comment #31)
> Comment on attachment 317117 [details] [review]
> hlsdemux: tests: add test of parsing the EXT-X-STREAM-INF tag
> 
> >hlsdemux: tests: add test of parsing the EXT-X-STREAM-INF tag
> 
> You are changing the behaviour of code here in a commit that says "add
> test", which seems suboptimal to me (although you do mention it of course).
> 

Yes, I think the commit message should be the other way around:
1. state that the commit causes quoted-string attributes to be unquoted
2. and describe that the unit tests have been updated to the new behaviour.

> So we just unconditionally unquote all values now?

Yes. The two other places that use quoted strings are for parsing the URI of
key files and index files. In both those cases they are unconditionally
unquoted.
We can now delete the unquote_string() function in m3u8.c because it happens
during m3u8 parsing.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.