[Bug 743345] glupload: Add support for dmabuf

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=743345

--- Comment #79 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 316605:
 --> (https://bugzilla.gnome.org/review?bug=743345&attachment=316605)

::: gst-libs/gst/gl/gstglupload.c
@@ +545,3 @@
+    for (i = 0; i < n; i++) {
+      GstStructure *s = gst_caps_get_structure (ret, i);
+      gst_structure_remove_fields (s, "texture-target", NULL);

Why is this the only place we need to do that ?

@@ +588,3 @@
+
+  if (gst_gl_context_check_feature (dmabuf->upload->context,
+          "EXT_image_dma_buf_import")) {

Why do you check this ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.