[Bug 743345] glupload: Add support for dmabuf

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=743345

--- Comment #80 from Julien Isorce <julien.isorce at gmail.com> ---
(In reply to Nicolas Dufresne (stormer) from comment #73)
> Review of attachment 316601 [details] [review]:
> 
> ::: gst-libs/gst/gl/gstglupload.c
> @@ +561,3 @@
> +    ret = _set_caps_features (caps, GST_CAPS_FEATURE_MEMORY_GL_MEMORY);
> +  } else {
> +    ret = _set_caps_features (caps, "memory:" GST_ALLOCATOR_DMABUF);
> 
> This is still wrong. We need a proper define and documentation for that caps
> feature before introducing it. In V4L2src, you will never require that caps
> feature, we will produce dmabuf regardless in the near future.

Lubosz, I know Nicolas said the above comment but then you replaced it by "ret
= _set_caps_features (caps, GST_CAPS_FEATURE_MEMORY_SYSTEM_MEMORY);"

I think you should set both. Upstream elements should still be aware of
GST_CAPS_FEATURE_MEMORY_DMABUF but it should not be a requirement.
(also see EGLIMAGE caps feature:
http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/gstglupload.c#n362)

Thx Lubosz for all that great work, I hope we can get all of this merge soon
enough.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.