[Bug 744520] gstutils: check uri before using it in gst_pad_create_stream_id_internal

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sun Feb 15 07:03:55 PST 2015


Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
             Status|NEW                         |NEEDINFO
                 CC|                            |t.i.m at zen.co.uk

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
This doesn't look like it should be required.

It's not allowed to call gst_query_set_uri() with a NULL uri, that would be a
programming mistake in the element that does that.

If an element can't answer an URI query successfully (i.e. return a valid URI),
it should return FALSE from the query function.

It seems to me that the only legitimate way gst_query_parse_uri() could return
a NULL URI is if an element didn't call gst_query_set_uri() but still returns
TRUE from the query function. Which would clearly be a bug IMHO.

It "doesn't hurt" to check of course, but I don't know if we want to work
around bugs like that.

You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

More information about the gstreamer-bugs mailing list