[Bug 744520] gstutils: check uri before using it in gst_pad_create_stream_id_internal

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sun Feb 15 07:25:44 PST 2015


--- Comment #3 from Matthieu Bouron <matthieu.bouron at collabora.com> ---
I agree with you that it's not allowed to call gst_query_set_uri with a NULL
uri (it outputs a bunch of critical warnings) and that the element which
implements the handler should not do that and returns FALSE in the query
handler instead.

But I don't see the fix as a work-around for the original issue but a counter
measure to avoid a crash (segmentation fault). Faulty implementations will
still receives the critical warnings and thus, still have a chance to get
Receiving a segfault to fix this kind of errors is a bit too extreme IMHO. What
do you think ?
I guess the related documentation of gst_query_set_uri might also be updated to
warn users about it.

You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

More information about the gstreamer-bugs mailing list