[Bug 744520] gstutils: check uri before using it in gst_pad_create_stream_id_internal

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sun Feb 15 07:46:16 PST 2015


--- Comment #4 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
You should be already receiving a critical from the guards in
gst_query_set_uri() (the gst_uri_is_valid() check) in that case. After such a
critical, all bets are off anyway.

If you can reduce your patch to a simple if (uri != NULL), that might be
acceptable, but we don't do GST_FIXME log messages for things like this.

Feel free to improve the docs for gst_query_set_uri(). The way the docs work is
that if NULL is allowed as a parameter for strings or other pointers, that is
explicitly marked (by means of an allow-none g-i annotation and an "or NULL" in
the text). It seems intuitive to me that setting NULL URIs onto a query does
not make much sense, but feel free to clarify :)

You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

More information about the gstreamer-bugs mailing list