[Bug 743311] mpeg2dec does not cope if downstream buffer allocation has stride != width

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Jan 21 11:31:23 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=743311
  GStreamer | gst-plugins-ugly | git master

--- Comment #2 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> 2015-01-21 19:31:21 UTC ---
Review of attachment 295127:
 --> (https://bugzilla.gnome.org/review?bug=743311&attachment=295127)

::: ext/mpeg2dec/gstmpeg2dec.c
@@ +559,3 @@
+  g_assert (GST_VIDEO_FRAME_PLANE_STRIDE (&vframe, 1) == chroma_stride);
+  g_assert (GST_VIDEO_FRAME_PLANE_STRIDE (&vframe, 2) == chroma_stride);
+  mpeg2_stride (mpeg2dec->decoder, GST_VIDEO_FRAME_PLANE_STRIDE (&vframe, 0));

A buffer could be allocated during decide_allocation(), this way you can check
this and reject the pool if not met ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list