[Bug 743311] mpeg2dec does not cope if downstream buffer allocation has stride != width

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=743311
  GStreamer | gst-plugins-ugly | git master

--- Comment #3 from Simon Farnsworth <simon at farnz.org.uk> 2015-01-22 12:54:48 UTC ---
(In reply to comment #2)
> Review of attachment 295127 [details]:
> 
> ::: ext/mpeg2dec/gstmpeg2dec.c
> @@ +559,3 @@
> +  g_assert (GST_VIDEO_FRAME_PLANE_STRIDE (&vframe, 1) == chroma_stride);
> +  g_assert (GST_VIDEO_FRAME_PLANE_STRIDE (&vframe, 2) == chroma_stride);
> +  mpeg2_stride (mpeg2dec->decoder, GST_VIDEO_FRAME_PLANE_STRIDE (&vframe, 0));
> 
> A buffer could be allocated during decide_allocation(), this way you can check
> this and reject the pool if not met ?

I'm not clear on how I'd do that safely.

Can I assume that the pool is active during decide_allocation? If not, is it
safe for me to active and deactivate it?

Can I use the GstVideoDecoder allocation functions to get a buffer and release
it at this point, or do I not have enough state set up yet (what *is* "enough
state" in this context)?

If I can't use the GstVideoDecoder allocation functions, where do I get my
GstVideoInfo from?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.