[Bug 740502] Add absolute property to GstDirectControlBinding
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Wed Jan 21 13:19:31 PST 2015
https://bugzilla.gnome.org/show_bug.cgi?id=740502
GStreamer | gstreamer (core) | git master
Stefan Sauer (gstreamer, gtkdoc dev) <ensonic> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #291987|none |needs-work
status| |
--- Comment #5 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2015-01-21 21:19:27 UTC ---
Review of attachment 291987:
--> (https://bugzilla.gnome.org/review?bug=740502&attachment=291987)
I think it looks good (besides the name for the constructor). I still like to
see some testing. We also have tests/examples/controller - maybe your example
can be merged there? Can you try that as a 2nd patch?
::: libs/gst/controller/gstdirectcontrolbinding.c
@@ +532,3 @@
+ */
+GstControlBinding *
+ *
perhaps
gst_direct_control_binding_new_absolute() ?
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list