[Bug 747728] vp8enc: multipass-mode=2 is not working

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747728

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #307132|none                        |needs-work
             status|                            |

--- Comment #19 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 307132:
 --> (https://bugzilla.gnome.org/review?bug=747728&attachment=307132)

::: ext/vpx/gstvp8enc.c
@@ +761,3 @@
   gst_vp8_enc->cfg.g_pass = DEFAULT_MULTIPASS_MODE;
+  gst_vp8_enc->multipass_cache_prefix = g_strdup
(DEFAULT_MULTIPASS_CACHE_FILE);
+  gst_vp8_enc->multipass_cache_prefix = NULL;

This code seems to dup a string, then set it to NULL. This seems like a bug
(and a leak).

@@ +805,3 @@

+  g_free (gst_vp8_enc->multipass_cache_prefix);
+  gst_vp8_enc->multipass_cache_prefix = NULL;

Note for future (you are following the style so not your fault) finalize() is
never called twice, so there is no need to reset the value to NULL or zero.

@@ +913,3 @@
+      if (gst_vp8_enc->multipass_cache_prefix)
+        g_free (gst_vp8_enc->multipass_cache_prefix);
+      gst_vp8_enc->multipass_cache_prefix = g_value_dup_string (value);

So are you changing the meaning of an existing property ? This seems like an
API break.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.