[Bug 747728] vp8enc: multipass-mode=2 is not working

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747728

--- Comment #20 from Oleksij Rempel <bug-track at fisher-privat.net> ---
(In reply to Nicolas Dufresne (stormer) from comment #19)
> Review of attachment 307132 [details] [review]:
> 
> ::: ext/vpx/gstvp8enc.c
> @@ +761,3 @@
>    gst_vp8_enc->cfg.g_pass = DEFAULT_MULTIPASS_MODE;
> +  gst_vp8_enc->multipass_cache_prefix = g_strdup
> (DEFAULT_MULTIPASS_CACHE_FILE);
> +  gst_vp8_enc->multipass_cache_prefix = NULL;
> 
> This code seems to dup a string, then set it to NULL. This seems like a bug
> (and a leak).

oops, you right.

> 
> @@ +805,3 @@
>  
> +  g_free (gst_vp8_enc->multipass_cache_prefix);
> +  gst_vp8_enc->multipass_cache_prefix = NULL;
> 
> Note for future (you are following the style so not your fault) finalize()
> is never called twice, so there is no need to reset the value to NULL or
> zero.

ok

> @@ +913,3 @@
> +      if (gst_vp8_enc->multipass_cache_prefix)
> +        g_free (gst_vp8_enc->multipass_cache_prefix);
> +      gst_vp8_enc->multipass_cache_prefix = g_value_dup_string (value);
> 
> So are you changing the meaning of an existing property ? This seems like an
> API break.

yes, i was thinking about it too. Any idea how to solve it without braking the
api?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.