[Bug 687182] playbin: autoplugging s/w and h/w accelerated deinterlacers
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Tue Jun 9 06:40:36 PDT 2015
https://bugzilla.gnome.org/show_bug.cgi?id=687182
Jan Schmidt <thaytan at noraisin.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #290892|none |needs-work
status| |
--- Comment #60 from Jan Schmidt <thaytan at noraisin.net> ---
Review of attachment 290892:
--> (https://bugzilla.gnome.org/review?bug=687182&attachment=290892)
::: gst/playback/gstplaysink.c
@@ +3246,3 @@
+ const gchar *s;
+ guint tmpl_caps_size, i, j;
+ GstPlaySinkInterlaceMode in_mode, sink_mode;
Seems like these can be used uninitialised below.
@@ +3308,3 @@
+ sink_mode != MODE_INTERLACED)
+ need_deinterlacer = TRUE;
+ }
I'm not sure what the difference between these 2 cases is in practice.
If playsink has the deinterlace flag set, we need a deinterlacer if the input
is interlaced or unspecified and the sink wants progressive vs otherwise only
if the input is explicitly interlaced?
Add a comment explaining the reasoning?
@@ +3747,3 @@
playsink->vischain->vissinkpad);
+ gst_ghost_pad_set_target (GST_GHOST_PAD_CAST (playsink->vischain->
+ srcpad), NULL);
Everything here an below seem like accidental whitespace changes
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list