[Bug 687182] playbin: autoplugging s/w and h/w accelerated deinterlacers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=687182

Jan Schmidt <thaytan at noraisin.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #290004|none                        |reviewed
             status|                            |

--- Comment #61 from Jan Schmidt <thaytan at noraisin.net> ---
Review of attachment 290004:
 --> (https://bugzilla.gnome.org/review?bug=687182&attachment=290004)

The maximum number of caps-features in common metric is a bit weird, and the
whitespace changes need to go, but otherwise seems OK

::: gst/playback/gstplaysink.c
@@ +1500,3 @@
   }

+  /* find the deinterlacer which has more number of common capsfeatures

more -> "the largest" /randomenglishnitpick

This seems like a funny metric for deciding on the best match, but I'm not sure
of a better one

@@ +1506,3 @@
+      gst_element_factory_list_get_elements
+      (GST_ELEMENT_FACTORY_TYPE_MEDIA_VIDEO |
+      GST_ELEMENT_FACTORY_TYPE_MEDIA_IMAGE, GST_RANK_NONE);

Should we ever autoplug elements with rank NONE?

@@ +3640,3 @@
             playsink->vischain->vissinkpad);
+        gst_ghost_pad_set_target (GST_GHOST_PAD_CAST (playsink->
+                vischain->srcpad), NULL);

whitespace changes below to remove.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.