[Bug 750761] inputselector: Handle different duration track selection

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750761

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #305125|none                        |needs-work
             status|                            |

--- Comment #18 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 305125:
 --> (https://bugzilla.gnome.org/review?bug=750761&attachment=305125)

::: gst/gstpad.c
@@ +4829,3 @@
+    GST_OBJECT_FLAG_UNSET (pad, GST_PAD_FLAG_EOS);
+    remove_event_by_type (pad, GST_EVENT_EOS);
+    GST_OBJECT_FLAG_UNSET (pad, GST_PAD_FLAG_EOS);

Why remove the flag twice? :) Please update the patch to only do it once, and
also add the GST_LOG_OBJECT() from the other places here

And shouldn't the code in push_event/send_event already have done this?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.