[Bug 750761] inputselector: Handle different duration track selection
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Fri Jun 12 03:45:49 PDT 2015
https://bugzilla.gnome.org/show_bug.cgi?id=750761
Sebastian Dröge (slomo) <slomo at coaxion.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #305127|none |needs-work
status| |
--- Comment #19 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 305127:
--> (https://bugzilla.gnome.org/review?bug=750761&attachment=305127)
::: plugins/elements/gstinputselector.c
@@ +114,2 @@
#define DEFAULT_SYNC_STREAMS TRUE
+#define DEFAULT_SYNC_MODE GST_INPUT_SELECTOR_SYNC_MODE_CLOCK
Don't change the default, it doesn't generally make sense to use the clock sync
mode
@@ +478,3 @@
case GST_EVENT_FLUSH_STOP:
+ /* Shouldn't use gst_selector_pad_reset () to avoid reset events_pending
+ * as still need send sticky event when switch to one EOS track and seek
FLUSH_STOP should reset everything, EOS and SEGMENT sticky events (of this
pad!) should go away at least. Others not so much
Can you make gst_selector_pad_reset() take a boolean parameter for switching
between these?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list