[Bug 750863] tests: dashdemux: added unit tests for parsing period element

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750863

--- Comment #11 from Florin Apostol <florin.apostol at oregan.net> ---
(In reply to Sebastian Dröge (slomo) from comment #8)
> Review of attachment 305323 [details] [review]:
> 
> ::: tests/check/elements/dash_mpd.c
> @@ +59,3 @@
>    GstMpdClient *mpdclient = gst_mpd_client_new ();
>  
> +  ret = gst_mpd_parse (mpdclient, xml, (gint) strlen (xml));
> 
> Does it make sense to use gint for this function? Shouldn't it be gsize or
> guint instead?

The declaration of gst_mpd_parse is:
gboolean gst_mpd_parse (GstMpdClient *client, const gchar *data, gint size);

In my opinion size should have the type gsize. But I don't want to make changes
in the interface of dashdemux parser. I don't think somebody will use a
negative value for size, but you never know.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.