[Bug 750863] tests: dashdemux: added unit tests for parsing period element

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Jun 24 02:58:41 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=750863

--- Comment #12 from Florin Apostol <florin.apostol at oregan.net> ---
(In reply to Sebastian Dröge (slomo) from comment #9)
> Review of attachment 305325 [details] [review]:
> 
> Looks generally good, but needs changing if the first two patches need
> changes
> 
> ::: tests/check/elements/dash_mpd.c
> @@ +354,3 @@
> +  GstMpdClient *mpdclient = gst_mpd_client_new ();
> +
> +  ret = gst_mpd_parse (mpdclient, xml, (gint) strlen (xml));
> 
> Same comment about the gint here
> 
> @@ +360,3 @@
> +  assert_equals_string (periodNode->id, "TestId");
> +  assert_equals_int64 (periodNode->start,
> +      (gint64) duration_to_ms (0, 1, 2, 12, 10, 20, 123));
> 
> and assert_equals_uint64() here

start has type gint64. I don't think it can be negative, but until we correct
its type, we must use assert_equals_int64

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list