[Bug 751334] FLAC: memory leak on a specific media file

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751334

--- Comment #23 from Vineeth <vineeth.tm at samsung.com> ---
The problem here is libflac is not able to handle this particular file due to
wrong header. StreamInfo is there twice in it. And on processing metadata it
just says exits by changing the state to FLAC__STREAM_DECODER_ABORTED
Hence even though data is valid, the decoder is not able to handle it.


I saw in the file history that this particular piece of code is added in the
below commit which was done almost 4 years back :)
http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/ext/flac/gstflacdec.c?id=a49818f876d9112b11def8aae2fdd72930e8b3e3

and the description mentions
flacdec: parse stream headers from caps in set_format function
Not that this seems to be actually needed, libflac happily decodes
stuff even if we just drop all headers and never feed it to the
library.

So libflac has been this way for a long time and does not seem to need header.


and metadata extraction is being taken care by parser i guess.
The code for metadata extraction has been removed in the below commit, again
almost 4 years back :)
http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/ext/flac/gstflacdec.c?id=ab591b6d536d5ede62d6629dc8ed2a1d58a222ee



One solution i can think of involves, 
not passing to header to decoder only when the header is corrupted. But this
might need some value being set in streamheader structure of caps from parser
and using that to decide if it needs to be passed to decoder or not.
But not sure if this is a good solution..

Please advice on how to proceed..

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.