[Bug 751334] FLAC: memory leak on a specific media file

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751334

--- Comment #24 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
I have the feeling this bug is going in the wrong direction. First, libflac
need to parse the header which are both in the stream and in the caps. If you
where to do it from caps and again from the stream, I can understand libflac
getting confused. There is benefits of doing from caps, one if that if it
fails, you can fail on caps event, and that will let decodebin pick the next
flac decoder in queue (if you are lucky to have one).

Now, *if* we want to support this broken file (because we know it's slightly
broken), the solution should resides in flacparse. The parser should detect
that the stream header has twice the stream info (hence the stream header is
like two headers in one). Base on that, the parser could "fix" the header by
only keeping the most recent one. Again, this is all about if we care
supporting this broken file.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.