[Bug 751311] rtp: Dynamic dropout / reorder limits

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751311

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #306421|none                        |needs-work
             status|                            |

--- Comment #33 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 306421:
 --> (https://bugzilla.gnome.org/review?bug=751311&attachment=306421)

::: gst/rtpmanager/rtpstats.c
@@ +78,3 @@
+  }
+
+  return MAX (RTP_MIN_DROPOUT, ctx->avg_packet_rate * time_ms / 1000);

I still don't like this minimum value (and the one for the misorder). What
about setting a minimum value for the packet rate instead? The minimum you have
there would allow very very low limits for dropout, which too easily can lead
to false positives.

> return MAX (RTP_MIN_DROPOUT_OR_MISORDER_PACKET_RATE, ctx->avg_packet_rate) * time_ms / 1000

and RTP_MIN_DROPOUT_OR_MISORDER_PACKET_RATE would be 50 (example from the RFC)

::: gst/rtpmanager/rtpstats.h
@@ +192,2 @@
 /*
+ * The default and eht minimum values of the maximum number of misordered
packets we tolerate.

typo: eht -> the (but in the other comment you omitted the "the" completely, so
just remove it here)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.