[Bug 751311] rtp: Dynamic dropout / reorder limits

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751311

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #306418|none                        |needs-work
             status|                            |

--- Comment #34 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 306418:
 --> (https://bugzilla.gnome.org/review?bug=751311&attachment=306418)

::: gst/rtpmanager/rtpsource.c
@@ +227,3 @@
+      g_param_spec_int ("max-dropout-time", "Max dropout time",
+          "The maximum time (milliseconds) of missing packets tolerated.",
+          -1, G_MAXINT, DEFAULT_MAX_DROPOUT_TIME,

-1 has no meaning here anymore, maybe set the minimum value to 2s or something?

@@ +233,3 @@
+      g_param_spec_int ("max-misorder-time", "Max misorder time",
+          "The maximum time (milliseconds) of misordered packets tolerated.",
+          -1, G_MAXINT, DEFAULT_MAX_MISORDER_TIME,

And same here, maybe just set it to 30s or so

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.