[Bug 745455] dashdemux doesn't take the presentationTimeOffset into account.

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Mar 5 07:56:12 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=745455

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #298289|none                        |reviewed
             status|                            |

--- Comment #8 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 298289:
 --> (https://bugzilla.gnome.org/review?bug=745455&attachment=298289)

::: ext/dash/gstmpdparser.c
@@ +3626,3 @@
+        offset /= stream->cur_seg_template->MultSegBaseType->
+            SegBaseType->timescale;
+    }

Why not store this somewhere easier already scaled to the timestamp to avoid
this long if here?

Just having a stream->presentationTimeOffset that you can simply add below
makes this clearer.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list