[Bug 745455] dashdemux doesn't take the presentationTimeOffset into account.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745455

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #298288|none                        |reviewed
             status|                            |

--- Comment #9 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 298288:
 --> (https://bugzilla.gnome.org/review?bug=745455&attachment=298288)

::: gst-libs/gst/adaptivedemux/gstadaptivedemux.c
@@ +745,3 @@
     stream->segment = demux->segment;
+    stream->segment.start = stream->segment.position = stream->segment.time =
+        stream->fragment.timestamp;

There is some other magic in other part of adaptivedemux to take care of live
streams start time to avoid delaying playback start for them.

I think just somehow doing "segment.start/.position += presentationOffset;"
would be a good enough solution here. Perharps some deeper changes would be
needed in adaptivedemux to expose this to subclasses.

Also, I don't think 'time' should change here. The stream-time should start
from 0 anyway.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.