[Bug 744383] directsoundsrc: volume and mute control

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=744383

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #296667|none                        |reviewed
             status|                            |

--- Comment #2 from Julien Isorce <julien.isorce at gmail.com> ---
Review of attachment 296667:
 --> (https://bugzilla.gnome.org/review?bug=744383&attachment=296667)

Hi, thx for the patch. That's good you implemented the gststreamvolume
interface for directsoundsrc.
I don't see anything wrong. I am not against using the MIXER interface. Was it
not possible to do something similar than directsoundsink ?
(http://cgit.freedesktop.org/gstreamer/gst-plugins-good/tree/sys/directsound/gstdirectsoundsink.c#n829)
It has the advantage to avoid looking for the right device.

::: sys/directsound/Makefile.am
@@ +6,3 @@
 libgstdirectsoundsrc_la_LIBADD = \
     $(GST_BASE_LIBS) $(GST_PLUGINS_BASE_LIBS) -lgstaudio-$(GST_API_VERSION) \
+    $(DIRECTX_LDFLAGS) -lwinmm -ldsound

It should be $(DIRECTSOUND_LIBS) (like for directsounsink element in -good
package)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.