[Bug 744383] directsoundsrc: volume and mute control

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=744383

--- Comment #3 from Victor Toso <me at victortoso.com> ---
(In reply to Julien Isorce from comment #2)
> Review of attachment 296667 [details] [review]:

Thank you for the review.

> I don't see anything wrong. I am not against using the MIXER interface. Was
> it not possible to do something similar than directsoundsink ?
> (http://cgit.freedesktop.org/gstreamer/gst-plugins-good/tree/sys/directsound/
> gstdirectsoundsink.c#n829)
> It has the advantage to avoid looking for the right device.

It is a bit easier for IDirectSoundBuffer as it has SetVolume which is not the
case for the CaptureBuffer :-(
I looked for a way to avoid the search for the right device but looks like this
is how this Mixer API works. I'm not a windows expert so I could be wrong here.

> 
> ::: sys/directsound/Makefile.am
> @@ +6,3 @@
>  libgstdirectsoundsrc_la_LIBADD = \
>  	$(GST_BASE_LIBS) $(GST_PLUGINS_BASE_LIBS) -lgstaudio-$(GST_API_VERSION) \
> +	$(DIRECTX_LDFLAGS) -lwinmm -ldsound
> 
> It should be $(DIRECTSOUND_LIBS) (like for directsounsink element in -good
> package)

Thanks, fixed!

It is worth noting that I've tested it with 1.4 as I'm building with
mingw-packages in fedora.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.