[Bug 746249] aggregator: Add gap event support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746249

--- Comment #6 from Reynaldo H. Verdejo Pinochet <reynaldo at opendot.cl> ---
Hi Thibault. Thanks for your review.

(In reply to Thibault Saunier from comment #5)
> Review of attachment 299670 [details] [review]:
> 
> A little unit test would be nice :)

Yes. Will add one.

> 
> ::: gst-libs/gst/base/gstaggregator.c
> @@ +933,3 @@
> +      gapbuf = gst_buffer_new ();
> +
> +      GST_BUFFER_PTS (gapbuf) = pts;
> 
> You should set DTS = PTS I think.

Noted. You are right. Will add that to the next iteration.

> 
> @@ +938,3 @@
> +      GST_BUFFER_FLAG_SET (gapbuf, GST_BUFFER_FLAG_DROPPABLE);
> +
> +      gapbuf = gst_buffer_new ();
> 
> Why do you think you should chain it this way? It might work and actually be
> a nice solution but looks weird at first sight.

Not sure what are you referring to here. Maybe you are
talking about using _pad_chain() instead of calling
the chain function directly? Can you elaborate please?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.