[Bug 746249] aggregator: Add gap event support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746249

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 299670:
 --> (https://bugzilla.gnome.org/review?bug=746249&attachment=299670)

::: gst-libs/gst/base/gstaggregator.c
@@ +938,3 @@
+      GST_BUFFER_FLAG_SET (gapbuf, GST_BUFFER_FLAG_DROPPABLE);
+
+      if (gst_pad_chain (pad, gapbuf) == GST_FLOW_ERROR) {

I think that way of chaining is correct, you could also just call the chain
function yourself but the above actually seems a bit cleaner.

However compare to != GST_FLOW_OK instead of == GST_FLOW_ERROR here.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.