[Bug 731791] videometa: add GstVideoAffineTransformationMeta

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=731791

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #315115|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 315115:
 --> (https://bugzilla.gnome.org/review?bug=731791&attachment=315115)

::: gst-libs/gst/video/gstvideoaffinetransformationmeta.c
@@ +28,3 @@
+  static volatile GType type = 0;
+  static const gchar *tags[] =
+      { GST_META_TAG_VIDEO_STR, GST_META_TAG_MEMORY_STR, NULL };

Why memory? This should only affect "video" and maybe "video-orientation" or
something like that

@@ +99,3 @@
+ * @buffer: a #GstBuffer
+ * @matrix: a 4x4 transformation matrix
+ * @get_matrix: a custom get_matrix function to be used by the

This functions has no matrix and get_matrix parameters. Why doesn't it have a
matrix parameter? :)

@@ +144,3 @@
+        GST_ERROR ("%i %i %i", i, j, k);
+        GST_ERROR ("%f", meta->matrix[i + (k * 4)]);
+        GST_ERROR ("%f", matrix[k + (j * 4)]);

Forgot to remove debug output here

::: gst-libs/gst/video/gstvideoaffinetransformationmeta.h
@@ +60,3 @@
+
+void gst_video_affine_transformation_meta_apply_matrix                        
  (GstVideoAffineTransformationMeta * meta,
+                                                                              
   gfloat * matrix);

Could also make that a "gfloat matrix[16]" which is basically the same but
provides more information about the intent.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.